options.auth passes straight through to request library. #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason to do this is so that we don't re-do the functionality that
request
has already made for us. This way users can use OAuth Tokens or any other authentication strategy supported byrequest
, but still remains backwards compatible with thecradle
API.I'm in the midst of providing a
request
pass through option to opencradle
up to the full functionality. Configuration in general could use a re-work, but would definitely lead to breaking changes in most areas. In my opinion, 90% ofcradle
's configuration variables configurerequest
and thereforecradle
should pick off the values it needs and just pass the rest torequest
.