[node] npm provider's generated-sources.json missing many packages (ENOTCACHED)
#377
Comments
2 tasks
p2004a
added a commit
to p2004a/info.beyondallreason.bar
that referenced
this issue
Mar 3, 2024
As part of the update, I had to refactor quite a bit of how the build process works. flatpak-node-generator is quite bugged: - Output `generated-source.json` expects the package to be in the main directory, so I've split the build into modules but still had to add `flatpak-node` exclusion to build - I had to patch locally flatpak/flatpak-builder-tools#382 and use that because flatpak/flatpak-builder-tools#381 - I've also run into flatpak/flatpak-builder-tools#377 I've also: - Made copying of addr2line dependencies more reliable - Merged the startup scripts into one - Added permission and setup for discord so that rich presence works
p2004a
added a commit
to p2004a/info.beyondallreason.bar
that referenced
this issue
Mar 3, 2024
As part of the update, I had to refactor quite a bit of how the build process works. flatpak-node-generator is quite bugged: - Output `generated-source.json` expects the package to be in the main directory, so I've split the build into modules but still had to add `flatpak-node` exclusion to build - I had to patch locally flatpak/flatpak-builder-tools#382 and use that because flatpak/flatpak-builder-tools#381 - I've also run into flatpak/flatpak-builder-tools#377 I've also: - Made copying of addr2line dependencies more reliable - Merged the startup scripts into one - Added permission and setup for discord so that rich presence works
p2004a
added a commit
to flathub/info.beyondallreason.bar
that referenced
this issue
Mar 3, 2024
As part of the update, I had to refactor quite a bit of how the build process works. flatpak-node-generator is quite bugged: - Output `generated-source.json` expects the package to be in the main directory, so I've split the build into modules but still had to add `flatpak-node` exclusion to build - I had to patch locally flatpak/flatpak-builder-tools#382 and use that because flatpak/flatpak-builder-tools#381 - I've also run into flatpak/flatpak-builder-tools#377 I've also: - Made copying of addr2line dependencies more reliable - Merged the startup scripts into one - Added permission and setup for discord so that rich presence works
julianfairfax
added a commit
to signalflatpak/signal
that referenced
this issue
Oct 16, 2024
Workaround for flatpak/flatpak-builder-tools#377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
flatpak-builder version
1.3.3
Linux distribution and version
Fedora 38
Affected flatpak-builder tool
node/flatpak-node-generator.py
flatpak-builder tool cli args
No response
Source repository URL
No response
Flatpak-builder manifest URL
No response
Description
I have found many sources are missing from
generated-sources.jsonwhen using the npm provider (under certain conditions). When it comes to running the flatpak-builder you see something like this:I have a
package-lock.jsonwith over 1000 packages butflatpak-node-generatoronly produces 90 sources.When I debugged the code of
flatpak-node-generatorI could see it was treating many packages' source as being of typeLocalSource(which excludes them from generated sources) despite that not being the case. This is due (I believe) to a subtle bug in the code where if a package json file exists for a package in a localnode_modulesdir whereflatpak-node-generatoris run then the package will always be treated as local.Deleting/renaming your
node_modulesdir before runningflatpak-node-generatorin the project's repository will workaround the issue but I am preparing a PR to fix the real issue also.I believe this may also be the same bug as #244 which was closed when the OP switched to yarn.
The text was updated successfully, but these errors were encountered: