Use all requested setting backends again [cont] #1538
Merged
+668
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swick
force-pushed
the
wip/findallimpls
branch
from
dbf450f to
252c532
Compare
Otherwise ASAN thinks we leak it, which is technically true, but not helpful.
Because they are getting ignored. Also fixes a memory leak when multiple default keys are specified.
swick
force-pushed
the
wip/findallimpls
branch
from
252c532 to
cc277eb
Compare
|
/cc @whot for the pytest changes |
Sodivad
reviewed
Dec 19, 2024
This broke with 4db11f7 which made find_all_portal_implementations use the same logic as find_portal_implementation and only make it use the first configured portal that was found. Notably if there's no portal config we would stil load multiple backends. Closes: flatpak#1535 Fixes: 4db11f7 ("portal-impl: Fix config ordering") Co-authored-by: Sebastian Wick <sebastian.wick@redhat.com>
This merges all the keys from different backends and prioritizes them according to the config. Merging overwrites previous values, so we loop through the impls in reverse order.
Instead of the default test backend interface.
This makes it possible to get the mock object from different busses and will be used when we spawn multiple backend implementations.
Currently, templates define the bus name in the global BUS_NAME but sometimes we want to spawn multiple template instances on different busses to test behavior with multiple backend implementations. This makes it possible to define the bus name a template will be spawned at with the required_templates fixture.
swick
force-pushed
the
wip/findallimpls
branch
from
cc277eb to
251cddd
Compare
GeorgesStavracas
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1536