fix(issue#6): Ensured wordnet and stopwords are loaded before used. #7
Conversation
| COPY src /app/build/src | ||
| COPY bonn /app/build/bonn | ||
| COPY pyproject.toml /app/build | ||
| COPY python/bonn /app/build/bonn |
There was a problem hiding this comment.
So presumably the build was broken until this change as src and bonn were in different levels?
There was a problem hiding this comment.
I'm not sure how the release was fine and where this happened, as I was a bit pressed for time on mrn, but when I tried to rebuild it locally bonn wasn't available only _bonn which is why I did this change.
Even after unziping the wheel only package available was _bonn.
Before the directory structure is:
├── _bonn/ # SRC code files
│ ├── _bonn.so file
Now it's :
├── bonn/ # Source code files
│ ├── _bonn.so file
│ ├── extract.py
│ ├── category_manager.py
│ ├── all bonn.py files
There was a problem hiding this comment.
After release I'm going to try on our onyx environment if there's any issues before writing to onyx.
Release shouldn't be an issue in their production environment. Because the bonn version they're using is 0.1.5 and I've updated for release to 0.1.6.
version used in ons
There was a problem hiding this comment.
The previous error.
…r-has-no-att fix(issue#6): Ensured wordnet and stopwords are loaded before used.
🐛 Bug Fix
Description
WordNetCorpusReader to have no attribute LazyCorpusLoaderissue in production server.Issue ticket: #6
Root Cause:
The bug is caused due to
WordNetCorpusReaderobject, used in theWordnetLemmatizer, hasn't fully loaded when the server, where we're callingCategoryManager, is ready to make requests.WordNetCorpusReaderhas a placeholder object , calledLazyCorpusLoader, to ensure other object load concurrently.Testing:
I've updated our environment with the new release to make sure server isn't ready to take calls when the
WordNetCorpusReaderis still loading.Steps to reproduce:
Can be found in issue #6
Screenshots:
Logs showing
LazyCorpusLoaderbefore and after ensuringWordNetCorpusReaderhas loaded, all before startup of server. Logs removed after test.Checklist
Who can review?
@philtweir