fix tests run with -race in server/mdm/scep #17274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheduled tests, which are run with `-race` are [failing][1], this was fixed in the `etcd-io/bbolt` fork of the now archived `boltdb/bolt`, for more details check [this issue][2]. since boltdb is used only for tests, and they're passing after switching to the fork, this seems like a reasonable way to fix them. [1]: https://github.com/fleetdm/fleet/actions/runs/8090809417 [2]: etcd-io/bbolt#391
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17274 +/- ##
==========================================
- Coverage 65.45% 65.34% -0.12%
==========================================
Files 1187 1187
Lines 106167 106167
Branches 2546 2546
==========================================
- Hits 69495 69371 -124
- Misses 31394 31506 +112
- Partials 5278 5290 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mostlikelee
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scheduled tests, which are run with
-raceare failing, this was fixed in theetcd-io/bboltfork of the now archivedboltdb/bolt, for more details check this issue.since boltdb is used only for tests, and they're passing after switching to the fork, this seems like a reasonable way to fix them.
Checklist for submitter
If some of the following don't apply, delete the relevant line.