Fix trivy fleetctl workflow #23643
Merged
Fix trivy fleetctl workflow #23643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
requested review from
lukeheath,
georgekarrv and
sharon-fdm
as code owners
lucasmrod
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
sgress454
approved these changes
Nov 11, 2024
sgress454
reviewed
Nov 11, 2024
Comment on lines
-26
to
+30
| contents: write | ||
| id-token: write # for aws-actions/configure-aws-credentials |
There was a problem hiding this comment.
guessing this is ok since the workflow passed, but confirming contents: write wasn't needed here?
There was a problem hiding this comment.
Yeah, probably a copy-paste residue when I created the workflow.
lukeheath
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly same fix as #23634.
PS: Thanks @sgress454!