add cpe translations to release #11
Conversation
clean up workflow
|
|
||
| # Note that a new commit must be made for each release, otherwise GitHub does not order | ||
| # the releases properly. | ||
| - name: Tag | ||
| if: hashFiles('fleet/*.sqlite.gz') != '' |
There was a problem hiding this comment.
just double checking: why did you decide to remove this? seems like this step will always run now, independently if new files were generated or not?
(is it because you have no way of telling if the json file has changed?)
There was a problem hiding this comment.
This was redundant. If any previous step fails, then this step won't run. No need to override the if condition to check if the file was correctly generated.
| @@ -33,23 +33,27 @@ jobs: | |||
| go-version: '^1.17.3' | |||
|
|
|||
| - name: Generate CPE database | |||
| run: cd fleet && go mod download && go run -tags fts5 cmd/cpe/generate.go && cat ./etagenv >> $GITHUB_ENV | |||
| run: | | |||
There was a problem hiding this comment.
Updated to be more readable. | preserves newlines. By default the shell is /bin/bash -e which means any errors cause an early exit so no need to && everything together.
This reverts commit 2004aaa.
| go mod download | ||
| go run -tags fts5 cmd/cpe/generate.go | ||
|
|
||
| - name: Current date |
There was a problem hiding this comment.
Use the current date for releases. If multiple releases are created on the same day, then github sorts in descending order by name. Using the etag (a hash) results in random order.
fleetdm/fleet#6628