-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery dep has problematic version in package.json #159
Comments
What do you mean by breaking versions? They break scrollTo or the fact that the major version changed? |
The second one, that it will install potentially breaking versions. |
Would moving it to a |
Not really, the best solution is just to stick to minor version in package.json, like: "^2.2.2" |
That would lock the plugin to only one major version at a time, which is incorrect and undesired |
Well, I think it is correct, because if some breaking change in major version is incompatible with your code, then you break all of you users code. But it's ofc up to you |
This notation:
"dependencies": { "jquery": ">=1.8" },
accepts also breaking versions (like 2.x, 3.x etc.), so it breaks semver security. It also creates problems when installing with yarn a package which hasjquery.scrollTo
as a dep:geniuscarrier/webpack-boilerplate#7
The text was updated successfully, but these errors were encountered: