Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant deps in prod build #7

Open
jalooc opened this issue Aug 25, 2017 · 2 comments
Open

Redundant deps in prod build #7

jalooc opened this issue Aug 25, 2017 · 2 comments

Comments

@jalooc
Copy link

jalooc commented Aug 25, 2017

Not really so production ready if there are two parallel 30k gzipped jquery deps ;)

image

@geniuscarrier
Copy link
Owner

@jalooc good call. Mind creating a pr to fix it?

@jalooc
Copy link
Author

jalooc commented Aug 28, 2017

Okay, just found out it happens only with yarn - jquery.scrollTo has jQuery dep at jquery@>=1.8 resolving to 3.2.1 and webpack-boilerplate denotes jquery@^2.2.2 which resolves currently to 2.2.4. Apparently, yarn has different deps flattening strategy and sees 2.2.4 !== 3.2.1, whilst npm takes the highest suitable for both: 2.2.4.

So it's up to you what to do:

  1. Disregard yarn users and do nothing;
  2. Update your jQuery dependency to sth gte 3.0.0;
  3. Poke jquery.scrollto package creators to drop the highly unreliable dep version scheme with >= which accepts all versions, even the breaking ones. <- this is the most legit option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants