Add "tableName" to execution log #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulMest
reviewed
Mar 4, 2019
| @@ -741,7 +741,8 @@ module.exports = { | |||
| if (index < migrationCommands.length) | |||
| { | |||
| let command = migrationCommands[index]; | |||
| console.log("[#"+index+"] execute: " + command.fn); | |||
| const tableName = (command.params && command.params[0]) || '<no table name>' | |||
There was a problem hiding this comment.
This project already depends on lodash. You could consider doing this instead:
const tableName = _.get(command, 'params[0]', '<no table name>');There was a problem hiding this comment.
@PaulMest thanks, I considered and in this specific case I feel like it comes down to personal preference, I don't see strong advantage of one or the other approach for the level of nesting of 2. For fields that are 3+ levels deep I think _.get has significant advantages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just makes output a little more readable.