Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg for fedora fixs #1410

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SteavenGamerYT
Copy link

No description provided.

@SteavenGamerYT
Copy link
Author

btw its still broken

FAILED: src/libMangoHud_dlsym.so
g++ -m32 -o src/libMangoHud_dlsym.so src/libMangoHud_dlsym.so.p/elfhacks.cpp.o src/libMangoHud_dlsym.so.p/real_dlsym.cpp.o src/libMangoHud_dlsym.so.p/hook_dlsym.cpp.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,-soname,libMangoHud_dlsym.so -Wl,--start-group src/libMangoHud.a subprojects/imgui-1.89.9/libimgui.a subprojects/spdlog-1.14.1/src/libspdlog.a subprojects/implot-0.16/libimplot.a -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,--exclude-libs,ALL -static-libstdc++ -Wl,--version-script,/home/omarhanykasban/Git/MangoHud/src/mangohud.version /usr/lib/libwayland-client.so /usr/lib/libxkbcommon.so -Wl,--end-group -pthread
/usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-redhat-linux/14/libstdc++.a when searching for -lstdc++
/usr/bin/ld: cannot find -lstdc++: No such file or directory
collect2: error: ld returned 1 exit status
[112/114] Linking target src/libMangoHud.so
FAILED: src/libMangoHud.so
g++ -m32 -o src/libMangoHud.so src/libMangoHud.a.p/vulkan.cpp.o src/libMangoHud.a.p/mesa_util_os_socket.c.o src/libMangoHud.a.p/mesa_util_os_time.c.o src/libMangoHud.a.p/hud_elements.cpp.o src/libMangoHud.a.p/overlay.cpp.o src/libMangoHud.a.p/overlay_params.cpp.o src/libMangoHud.a.p/font.cpp.o src/libMangoHud.a.p/keybinds.cpp.o src/libMangoHud.a.p/font_unispace.c.o src/libMangoHud.a.p/logging.cpp.o src/libMangoHud.a.p/config.cpp.o src/libMangoHud.a.p/gpu.cpp.o src/libMangoHud.a.p/blacklist.cpp.o src/libMangoHud.a.p/file_utils.cpp.o src/libMangoHud.a.p/cpu.cpp.o src/libMangoHud.a.p/memory.cpp.o src/libMangoHud.a.p/iostats.cpp.o src/libMangoHud.a.p/notify.cpp.o src/libMangoHud.a.p/elfhacks.cpp.o src/libMangoHud.a.p/real_dlsym.cpp.o src/libMangoHud.a.p/pci_ids.cpp.o src/libMangoHud.a.p/battery.cpp.o src/libMangoHud.a.p/control.cpp.o src/libMangoHud.a.p/device.cpp.o src/libMangoHud.a.p/amdgpu.cpp.o src/libMangoHud.a.p/intel.cpp.o src/libMangoHud.a.p/msm.cpp.o src/libMangoHud.a.p/net.cpp.o src/libMangoHud.a.p/shell.cpp.o src/libMangoHud.a.p/nvml.cpp.o src/libMangoHud.a.p/loaders_loader_nvml.cpp.o src/libMangoHud.a.p/loaders_loader_nvctrl.cpp.o src/libMangoHud.a.p/nvctrl.cpp.o src/libMangoHud.a.p/loaders_loader_x11.cpp.o src/libMangoHud.a.p/shared_x11.cpp.o src/libMangoHud.a.p/wayland_hook.cpp.o src/libMangoHud.a.p/wayland_keybinds.cpp.o src/libMangoHud.a.p/dbus.cpp.o src/libMangoHud.a.p/loaders_loader_dbus.cpp.o src/libMangoHud.a.p/meson-generated_.._.._vk_enum_to_str.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,-soname,libMangoHud.so -Wl,--start-group src/libMangoHud.a subprojects/imgui-1.89.9/libimgui.a subprojects/spdlog-1.14.1/src/libspdlog.a subprojects/implot-0.16/libimplot.a -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,--exclude-libs,ALL -static-libstdc++ -Wl,--version-script,/home/omarhanykasban/Git/MangoHud/src/mangohud.version /usr/lib/libwayland-client.so /usr/lib/libxkbcommon.so -Wl,--end-group -pthread
/usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-redhat-linux/14/libstdc++.a when searching for -lstdc++
/usr/bin/ld: cannot find -lstdc++: No such file or directory
collect2: error: ld returned 1 exit status
[113/114] Linking target src/libMangoHud_opengl.so
FAILED: src/libMangoHud_opengl.so
g++ -m32 -o src/libMangoHud_opengl.so src/libMangoHud_opengl.so.p/gl_glad.c.o src/libMangoHud_opengl.so.p/gl_gl_renderer.cpp.o src/libMangoHud_opengl.so.p/gl_gl_hud.cpp.o src/libMangoHud_opengl.so.p/gl_inject_egl.cpp.o src/libMangoHud_opengl.so.p/loaders_loader_glx.cpp.o src/libMangoHud_opengl.so.p/gl_inject_glx.cpp.o src/libMangoHud_opengl.so.p/hud_elements.cpp.o src/libMangoHud_opengl.so.p/overlay.cpp.o src/libMangoHud_opengl.so.p/overlay_params.cpp.o src/libMangoHud_opengl.so.p/font.cpp.o src/libMangoHud_opengl.so.p/keybinds.cpp.o src/libMangoHud_opengl.so.p/font_unispace.c.o src/libMangoHud_opengl.so.p/logging.cpp.o src/libMangoHud_opengl.so.p/config.cpp.o src/libMangoHud_opengl.so.p/gpu.cpp.o src/libMangoHud_opengl.so.p/blacklist.cpp.o src/libMangoHud_opengl.so.p/file_utils.cpp.o src/libMangoHud_opengl.so.p/cpu.cpp.o src/libMangoHud_opengl.so.p/memory.cpp.o src/libMangoHud_opengl.so.p/iostats.cpp.o src/libMangoHud_opengl.so.p/notify.cpp.o src/libMangoHud_opengl.so.p/elfhacks.cpp.o src/libMangoHud_opengl.so.p/real_dlsym.cpp.o src/libMangoHud_opengl.so.p/pci_ids.cpp.o src/libMangoHud_opengl.so.p/battery.cpp.o src/libMangoHud_opengl.so.p/control.cpp.o src/libMangoHud_opengl.so.p/device.cpp.o src/libMangoHud_opengl.so.p/amdgpu.cpp.o src/libMangoHud_opengl.so.p/intel.cpp.o src/libMangoHud_opengl.so.p/msm.cpp.o src/libMangoHud_opengl.so.p/net.cpp.o src/libMangoHud_opengl.so.p/shell.cpp.o src/libMangoHud_opengl.so.p/nvml.cpp.o src/libMangoHud_opengl.so.p/loaders_loader_nvml.cpp.o src/libMangoHud_opengl.so.p/loaders_loader_nvctrl.cpp.o src/libMangoHud_opengl.so.p/nvctrl.cpp.o src/libMangoHud_opengl.so.p/loaders_loader_x11.cpp.o src/libMangoHud_opengl.so.p/shared_x11.cpp.o src/libMangoHud_opengl.so.p/wayland_hook.cpp.o src/libMangoHud_opengl.so.p/wayland_keybinds.cpp.o src/libMangoHud_opengl.so.p/dbus.cpp.o src/libMangoHud_opengl.so.p/loaders_loader_dbus.cpp.o src/libMangoHud_opengl.so.p/mesa_util_os_socket.c.o src/libMangoHud_opengl.so.p/mesa_util_os_time.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,-soname,libMangoHud_opengl.so -Wl,--start-group src/libMangoHud.a subprojects/imgui-1.89.9/libimgui.a subprojects/spdlog-1.14.1/src/libspdlog.a subprojects/implot-0.16/libimplot.a -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,--exclude-libs,ALL -static-libstdc++ -Wl,--version-script,/home/omarhanykasban/Git/MangoHud/src/mangohud.version /usr/lib/libwayland-client.so /usr/lib/libxkbcommon.so -Wl,--end-group -pthread
/usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-redhat-linux/14/libstdc++.a when searching for -lstdc++
/usr/bin/ld: cannot find -lstdc++: No such file or directory
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

@SteavenGamerYT
Copy link
Author

its finaly fixed. pls acccept this

@flightlessmango
Copy link
Owner

A docker image with latest fedora does not require any more packages for installing.

@SteavenGamerYT
Copy link
Author

A docker image with latest fedora does not require any more packages for installing.

it did require them for me on fedora 41

@flightlessmango
Copy link
Owner

I see now, I can repro it in 41.
The problem stems from dnf list installed working differently.
The script assumes that running dnf list installed $package will return exit code 1 if the package is not installed, but that's not the case anymore.
Now it will instead return 0 even if it's not installed but exists in the repo.
This needs to be reworked some how

@SteavenGamerYT
Copy link
Author

SteavenGamerYT commented Aug 26, 2024

dnf list installed $package

did you know that you could just run dnf4? dnf4 is the old dnf

@flightlessmango
Copy link
Owner

We shouldn't base our code on a deprecated program.
It would also make it so we need to know which fedora version the host is running.
Best solution would be to work out a way that works with old and new dnf

@LionHeartP
Copy link

I see now, I can repro it in 41. The problem stems from dnf list installed working differently. The script assumes that running dnf list installed $package will return exit code 1 if the package is not installed, but that's not the case anymore. Now it will instead return 0 even if it's not installed but exists in the repo. This needs to be reworked some how

I think because for dnf5 --installed is the correct option so omitting the dashes just lists instead which would be the same for f40 and earlier if you just used dnf list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants