Skip to content

Commit

Permalink
Auto merge of rust-lang#8061 - vallentin:fix-same-name-method-desc, r…
Browse files Browse the repository at this point in the history
…=flip1995

Fixed same_name_method description

Noticed some odd phrasing, while checking out the new release.

changelog: none
  • Loading branch information
bors committed Dec 3, 2021
2 parents fddef24 + f26821c commit be1a73b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions clippy_lints/src/same_name_method.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use std::collections::{BTreeMap, BTreeSet};

declare_clippy_lint! {
/// ### What it does
/// It lints if a struct has two method with same time:
/// It lints if a struct has two methods with the same name:
/// one from a trait, another not from trait.
///
/// ### Why is this bad?
Expand Down Expand Up @@ -100,7 +100,7 @@ impl<'tcx> LateLintPass<'tcx> for SameNameMethod {
cx,
SAME_NAME_METHOD,
*impl_span,
"method's name is same to an existing method in a trait",
"method's name is the same as an existing method in a trait",
|diag| {
diag.span_note(
trait_method_span,
Expand Down Expand Up @@ -139,7 +139,7 @@ impl<'tcx> LateLintPass<'tcx> for SameNameMethod {
cx,
SAME_NAME_METHOD,
impl_span,
"method's name is same to an existing method in a trait",
"method's name is the same as an existing method in a trait",
|diag| {
// TODO should we `span_note` on every trait?
// iterate on trait_spans?
Expand Down
10 changes: 5 additions & 5 deletions tests/ui/same_name_method.stderr
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
error: method's name is same to an existing method in a trait
error: method's name is the same as an existing method in a trait
--> $DIR/same_name_method.rs:20:13
|
LL | fn foo() {}
Expand All @@ -11,7 +11,7 @@ note: existing `foo` defined here
LL | fn foo() {}
| ^^^^^^^^^^^

error: method's name is same to an existing method in a trait
error: method's name is the same as an existing method in a trait
--> $DIR/same_name_method.rs:44:13
|
LL | fn foo() {}
Expand All @@ -23,7 +23,7 @@ note: existing `foo` defined here
LL | fn foo() {}
| ^^^^^^^^^^^

error: method's name is same to an existing method in a trait
error: method's name is the same as an existing method in a trait
--> $DIR/same_name_method.rs:58:13
|
LL | fn foo() {}
Expand All @@ -35,7 +35,7 @@ note: existing `foo` defined here
LL | impl T1 for S {}
| ^^^^^^^^^^^^^^^^

error: method's name is same to an existing method in a trait
error: method's name is the same as an existing method in a trait
--> $DIR/same_name_method.rs:70:13
|
LL | fn foo() {}
Expand All @@ -47,7 +47,7 @@ note: existing `foo` defined here
LL | impl T1 for S {}
| ^^^^^^^^^^^^^^^^

error: method's name is same to an existing method in a trait
error: method's name is the same as an existing method in a trait
--> $DIR/same_name_method.rs:34:13
|
LL | fn clone() {}
Expand Down

0 comments on commit be1a73b

Please sign in to comment.