Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCOL-2356: Enable producers.persistent_connections setting #213

Merged
merged 1 commit into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## UNRELEASED
- Feature: Enable `producers.persistent_connections` phobos setting

# 1.24.1 - 2024-03-26
- Fix: ActiveRecordConsumer batch consumption was not working with the trilogy adapter.
Expand Down
3 changes: 2 additions & 1 deletion lib/deimos/config/phobos_config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ def phobos_config
compression_threshold: self.producers.compression_threshold,
max_queue_size: self.producers.max_queue_size,
delivery_threshold: self.producers.delivery_threshold,
delivery_interval: self.producers.delivery_interval
delivery_interval: self.producers.delivery_interval,
persistent_connections: self.producers.persistent_connections
},
consumer: {
session_timeout: self.consumers.session_timeout,
Expand Down
6 changes: 4 additions & 2 deletions spec/config/configuration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def consume
compression_threshold: 1,
max_queue_size: 10_000,
delivery_threshold: 0,
delivery_interval: 0
delivery_interval: 0,
persistent_connections: false
}
)
end
Expand Down Expand Up @@ -278,7 +279,8 @@ def consume
compression_threshold: 2,
max_queue_size: 10,
delivery_threshold: 1,
delivery_interval: 1
delivery_interval: 1,
persistent_connections: true
}
)
end
Expand Down
Loading