Add specs to shared adapter specs/tests for double enable of single t…

…hings
flippercloud · Jun 28, 2019 · 171457d · 171457d
1 parent db474e7
commit 171457d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/flipper/spec/shared_adapter_specs.rb b/lib/flipper/spec/shared_adapter_specs.rb
@@ -280,4 +280,14 @@
     expect(subject.enable(feature, group_gate, flipper.group(:admins))).to eq(true)
     expect(subject.get(feature).fetch(:groups)).to eq(Set['admins'])
   end
+
+  it 'can double enable percentage without error' do
+    expect(subject.enable(feature, actors_gate, flipper.actors(25))).to eq(true)
+    expect(subject.enable(feature, actors_gate, flipper.actors(25))).to eq(true)
+  end
+
+  it 'can double enable without error' do
+    expect(subject.enable(feature, boolean_gate, flipper.boolean)).to eq(true)
+    expect(subject.enable(feature, boolean_gate, flipper.boolean)).to eq(true)
+  end
 end
diff --git a/lib/flipper/test/shared_adapter_test.rb b/lib/flipper/test/shared_adapter_test.rb
@@ -275,6 +275,16 @@ def test_can_double_enable_a_group_without_error
         assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
         assert_equal Set['admins'], @adapter.get(@feature).fetch(:groups)
       end
+
+      def test_can_double_enable_percentage_without_error
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
+        assert_equal true, @adapter.enable(@feature, @actors_gate, @flipper.actors(25))
+      end
+
+      def test_can_double_enable_without_error
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+        assert_equal true, @adapter.enable(@feature, @boolean_gate, @flipper.boolean)
+      end
     end
   end
 end