Skip to content

Commit

Permalink
Keep writer around for now
Browse files Browse the repository at this point in the history
  • Loading branch information
bkeepers committed Apr 13, 2021
1 parent 2da6e1d commit e591c2e
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions lib/flipper/cloud/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,9 @@ def initialize(options = {})
end

if ENV["FLIPPER_CLOUD_SYNC_METHOD"]
warn "FLIPPER_CLOUD_SYNC_METHOD is deprecated and has no effect. Set FLIPPER_CLOUD_SYNC_SECRET to enable webhook syncing"
end

if options[:sync_method]
warn ":sync_method is deprecated and has no effect."
warn "FLIPPER_CLOUD_SYNC_METHOD is deprecated and has no effect."
end
self.sync_method = opts[:sync_method] if opts[:sync_method]

@instrumenter = options.fetch(:instrumenter, Instrumenters::Noop)
@read_timeout = options.fetch(:read_timeout) { ENV.fetch("FLIPPER_CLOUD_READ_TIMEOUT", 5).to_f }
Expand Down Expand Up @@ -123,6 +120,10 @@ def sync_method
sync_secret ? :webhook : :poll
end

def sync_method=(_)
warn "Flipper::Cloud: sync_method is deprecated and has no effect."
end

private

def app_adapter
Expand Down

0 comments on commit e591c2e

Please sign in to comment.