Implement UI::Configuration so users can customize Flipper UI text

[AlexWheeler]

spike on #63 to allow users to customize the Flipper UI text, curious what everyone thinks.

Flipper::UI.configure do |c|
  c.percentage_of_actors.title = "% of Actors"
  c.percentage_of_actors.description = "percentage of actors rule :)"

  c.actors.description = "Enable any actor by entering that actor's flipper_id"

  c.delete.title = "DO NOT PRESS!"
  c.delete.description = "Who knows what will happen?!"
end

results in:

I also played with the idea of making the configuration have a bit cleaner dsl something like. the latter is cleaner, but the above is simpler, would be cool to hear thoughts on this:

Flipper::UI.configure do |c|

  c.actors do
    title ""
    description ""
  end
  
end

[jnunemaker]

I like it! I'm 100% down with shipping this as is. Some thoughts for this PR or a follow up:

• feature_creation_enabled and application_breadcrumb_href - Should we move these into UI::Configuration? If we wanted backwards compatibility we could even make the current writer methods just update the configuration instance.

[jnunemaker]

I hit submit too soon. Lol.

I also played with the idea of making the configuration have a bit cleaner dsl something like. the latter is cleaner, but the above is simpler, would be cool to hear thoughts on this:

I like the way you did it. I'm a fan of pure/boring ruby over DSL's.

[AlexWheeler]

@jnunemaker great idea, I'll add move feature_creation_enabled / application_breadcrumb_href to UI::Configuration in next PR.

what do you think about the failing line length code climate issues for the strings. splitting them into multi lines to make code climate happy makes it messier imo

[jnunemaker]

I’m fine either way on line length. I usually don’t worry about stuff like that.

…

On Sat, Nov 18, 2017 at 1:25 PM Alex Wheeler ***@***.***> wrote: @jnunemaker <https://github.com/jnunemaker> great idea, I'll add move feature_creation_enabled / application_breadcrumb_href to UI::Configuration in next PR. what do you think about the failing line length code climate issues for the strings. splitting them into multi lines to make code climate happy makes it messier imo — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#306 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAA68Rmy4BdHgvr6UTJgrtYv1YNEhWyks5s3yEFgaJpZM4QiG2V> .