Sync Adapter #341
Merged
Sync Adapter #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long way to go yet. I still want this to: * sync from remote if local is blank * sync local from remote on interval
This is naive as it happens in the synchronous path instead of in a background thread but is ok to start.
This is to prevent the remote being unavailable from affecting the app other than a timeout every interval.
Need to get some units for each of them as well.
Also now instrumenting call so people can keep track of how often the synchronizer is invoking and how long it is taking.
Running into some weird stuff and I'm wondering if it is struct. Some kind of endless loop for both "p" and "pp" for operations.
|
I'm going to keep moving forward, but would love it if anyone would give this a look over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sync adapter. When you have a remote that is relatively latent (say http and not in same datacenter, region or whatever) and want a local "cache" that is more persistent than a cache (across process restarts and serves stale instead of raising if remote is unavailable), this adapter can come in handy.