Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Slashes in Feature Names in UI/API #362

Merged
merged 12 commits into from
Jul 31, 2018
Merged

Support Slashes in Feature Names in UI/API #362

merged 12 commits into from
Jul 31, 2018

Commits on May 20, 2018

  1. Add support for slashes in feature names to UI 

    refs #357

This is a tricky one. The issue is that I was assuming no one would use slashes. Using a slash completely broke all the routing. I changed the routing to be a block so it is more flexible. Now it is possible to route based on anything in request.

The API will likely need the same work.
    @jnunemaker
    jnunemaker committed May 20, 2018
    Configuration menu
    Copy the full SHA
    3033e3c View commit details
    Browse the repository at this point in the history

  2. Make it easy to only log requests but still log feature stuff if you … 

    …want it
    @jnunemaker
    jnunemaker committed May 20, 2018
    Configuration menu
    Copy the full SHA
    cccf29f View commit details
    Browse the repository at this point in the history

  3. Add a slash feature to the example

    @jnunemaker
    jnunemaker committed May 20, 2018
    Configuration menu
    Copy the full SHA
    569d8c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2018

  1. Add support for slashes in feature names to API 

    refs #357
refs 3033e3c
    @jnunemaker
    jnunemaker committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    1602d2e View commit details
    Browse the repository at this point in the history

  2. Make rubo happy by removing double negation

    @jnunemaker
    jnunemaker committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    de10683 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2018

  1. Merge branch 'master' into slash-names

    @jnunemaker
    jnunemaker committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    1acf979 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2018

  1. Switch to named captures for route regex

    @jnunemaker
    jnunemaker committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    f61bbe9 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2018

  1. Move back to single regex from overly flexible request match 

    We just need to match the path info to a regex. We don't need the whole request.
    @jnunemaker
    jnunemaker committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    8fa06a5 View commit details
    Browse the repository at this point in the history

  2. Dry up feature name from route

    @jnunemaker
    jnunemaker committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    d0ad3f8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into slash-names

    @jnunemaker
    jnunemaker committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    560927c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into slash-names

    @jnunemaker
    jnunemaker committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    f66b22f View commit details
    Browse the repository at this point in the history

  5. Another order change to fix test failure

    @jnunemaker
    jnunemaker committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    04aead8 View commit details
    Browse the repository at this point in the history