Include thing_value in payload of Instrumented#enable and #disable

[rafaelmillan]

When subscribing to notifications it can be useful to know the value of the gate being enabled/disabled. For example, that way you could set up notifications and output the name of the group or the percentage being changed.

This adds a new thing_value attribute to the payload of Instrumented#enable and Instrumented#disable.

Thanks for the great gem!

[jnunemaker]

For some reason I am on the fence about this, but I can't come up with a strong reason why not to and the PR is simple and tested so I'm going to merge. Thanks!

I think part of it might be that one could just do Flipper[feature_name].gate_values[gate_name] to get the value and it should be memoized (to avoid the extra read lookup).

[rafaelmillan]

Thank you for the approval 🙌

I think part of it might be that one could just do Flipper[feature_name].gate_values[gate_name] to get the value and it should be memoized (to avoid the extra read lookup).

I hadn't thought of that. I could be missing something but I think using your suggestion it still wouldn't be possible to find out which value was disabled for gates that use sets (groups and actors).

[jnunemaker]

I could be missing something but I think using your suggestion it still wouldn't be possible to find out which value was disabled for gates that use sets (groups and actors).

Great point.