Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec testing require of flipper-active_record.rb #438

Conversation

bendb-instacart
Copy link
Contributor

This will guard against regressions like that fixed in #437.

I manually validated that this spec generates an error prior to the fix in #437, and runs successfully after.

This will guard against regressions like that fixed in flippercloud#437.
@jnunemaker jnunemaker merged commit 4df5631 into flippercloud:master Sep 14, 2019
@bendb-instacart bendb-instacart deleted the test_require_active_record_adapter branch September 15, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants