Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Octicons and replace with a pure CSS status circle #547

Merged
merged 8 commits into from
Aug 12, 2021

Conversation

onesneakymofo
Copy link
Contributor

@onesneakymofo onesneakymofo commented Jul 30, 2021

For me, when I switched from the Rails asset pipeline over to Webpacker, the squirrel icons turned into little squares. I didn't want to have to download Octicons or create some hacky solution so I figured I would create a pull request to remove the icons altogether.

This pull request replaces the squirrels with a simple circle in the CSS and drops the trashcan icon in favor of the word Delete to match the other buttons on the page. It also saves 180kb most of which wasn't used.

Screenshots:
2021-07-30 at 2 01 AM

2021-07-30 at 2 02 AM

@thetimbanks
Copy link
Collaborator

I would be fine with making this change, but would like @jnunemaker to chime in just to make sure there isn't more to having the squirrel icons.

@jnunemaker
Copy link
Collaborator

I'll miss them but I'm fine with reducing dependencies. 👍

@jnunemaker
Copy link
Collaborator

I haven't checked this on mobile but I'm assuming it's fine. I'll merge it soon if @thetimbanks doesnt.

@jnunemaker
Copy link
Collaborator

I'd maybe go with remove instead of delete. I usually think add and remove or create and delete. Minor and I'd be curious if anyone else has any opinions on that.

@onesneakymofo
Copy link
Contributor Author

@jnunemaker Yep, contextually that makes a lot more sense. I've made the change.

@jnunemaker jnunemaker merged commit 3bac083 into flippercloud:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants