feat: make DialogFileBrowserOptions::new() use native initialization function
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarvisCraft
force-pushed
the
native-file-browser-options-init
branch
from
7ab64b2
to
70bf1c6
Compare
dcoles
reviewed
Jul 8, 2023
JarvisCraft
added a commit
to JarvisCraft/flipperzero-rs
that referenced
this pull request
Jul 11, 2023
JarvisCraft
added a commit
to JarvisCraft/flipperzero-rs
that referenced
this pull request
Jul 11, 2023
JarvisCraft
added a commit
to JarvisCraft/flipperzero-rs
that referenced
this pull request
Jul 11, 2023
str4d
reviewed
Aug 20, 2023
JarvisCraft
added a commit
to JarvisCraft/flipperzero-rs
that referenced
this pull request
Aug 20, 2023
str4d
reviewed
Aug 26, 2023
Merged
|
Build is failing. |
Yup, I am going to fix that, but now that cstr-literals are stabilized in 1.76, I may rework this PR to omit the redundant dependency. |
JarvisCraft
added a commit
to JarvisCraft/flipperzero-rs
that referenced
this pull request
Dec 3, 2023
JarvisCraft
force-pushed
the
native-file-browser-options-init
branch
3 times, most recently
from
deebdac
to
6ec32b2
Compare
|
Important Since this PR effectively depends on #120, Clippy should be fixed by the latter. |
JarvisCraft
force-pushed
the
native-file-browser-options-init
branch
from
6ec32b2
to
14ef1b9
Compare
JarvisCraft
force-pushed
the
native-file-browser-options-init
branch
4 times, most recently
from
7582078
to
b0ef9f9
Compare
JarvisCraft
force-pushed
the
native-file-browser-options-init
branch
from
b0ef9f9
to
4b67f07
Compare
JarvisCraft
force-pushed
the
native-file-browser-options-init
branch
from
4b67f07
to
bf865a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #80 safe bindings for dialogs app file browser were added by @mogenson. At this moment, the native initialization function was unsound since it forgot to initialize one of the fields so we decided to perform initialization on Rust side.
Now that this issues is fixed in flipperdevices/flipperzero-firmware#2756 with the future guarantee to always initialize all fields we can (and should) migrate to this approach which is better for us from backwards compatibility standpoint since we will no longer have to reflect the changes to this structure on our side for sake of safety.
Requirements
0.86.1which contains the required fix to thedialog_file_browser_set_basic_options.Notes
I've also added a
c_strmacro which has magically becomeconst-friendly with the recent stabilization offrom_bytes_with_nulwhich will land to stable soon (at least, by the time we are ready to become stable-friendly; anyways, it is behind a macro so there is no explicit dependency on unstable toolchain as for now).