This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Fix PopperJS instantiation (see issue #32) #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues relating to
this._popper
being undefined, like #32. My personal motivation for this change is an issue where when the popper overflows the boundaries element on initial render, the position doesn't get fixed until there's a resize event.I can create an example of this issue if you want. I can also add some tests to this PR.
Thanks for working on this lib, by the way!