Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Fix PopperJS instantiation (see issue #32) #77

Merged
merged 2 commits into from
Jan 8, 2018

Conversation

patreeceeo
Copy link
Contributor

@patreeceeo patreeceeo commented Dec 9, 2017

This fixes issues relating to this._popper being undefined, like #32. My personal motivation for this change is an issue where when the popper overflows the boundaries element on initial render, the position doesn't get fixed until there's a resize event.

I can create an example of this issue if you want. I can also add some tests to this PR.

Thanks for working on this lib, by the way!

@patreeceeo
Copy link
Contributor Author

patreeceeo commented Dec 10, 2017

So, I put together some code bins replicating my issue.

Here's a code bin showing my issue: https://www.webpackbin.com/bins/-L0-y6SHzbWdBcEn-lVf

Here's a code bin showing the issue fixed by these changes: https://www.webpackbin.com/bins/-L0-yRUS35RxpZS1XYAX

@sontek
Copy link

sontek commented Dec 19, 2017

hey @souporserious, any chance this PR could get reviewed?

@souporserious
Copy link
Collaborator

Sorry about the wait, I've been busy with work and the holidays. This looks great! Thanks for the examples and fixes, I really appreciate it 😃

@souporserious souporserious merged commit 1d08454 into floating-ui:master Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants