Increased timeout on captain requests using ky #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LatentDream
approved these changes
Sep 6, 2024
|
@jackparmer @itsjoeoui Can you guys merge this one, a lot of person have the infinite "Loading Blocks" problem on Windows 10/11. @rosiakpiotr found the root cause and fixed it |
|
Amazing! Thanks for your contribution @rosiakpiotr 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening pull request as a result of investigation of program hanging on "Loading Blocks" on Windows 11 system. Link to discord message for more information: https://discord.com/channels/1120876301809623050/1179493072212590673/1281582054957387777
Introduced change is changing time in milliseconds before request fails due to timeout error. On older machines the default value (10 * 1000) may be too small rendering "Loading Blocks" to be stuck and program becoming inoperable. This effect is observed on decent hardware with i5-12500H and 7 GB/s SSD drives. Did not investigate exact details what is the time consuming factor.
At first glance disabling timeout would make sure that requests to captain wouldn't fail due to this reason but realistically it is better to have timeout error thrown and handled in the UI (not the case at the time of writing), but with increased value to maybe half a minute - open to talk about the exact value but this one should work fine.