Use pyproject.toml instead of setup.py #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: mypy is throwing a lot of errors about the typescripting, etc. Please let me know if you do not want to keep this as a optional dependency. A subsequent PR would need to go through the issues and see which ones are relevant, if mypy is useful and we want to include it. |
|
@florafauna any thoughts on this? I went back to using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now strongly recommended to use a
pyproject.tomlfile instead of asetup.pyfile to declare the setup for the packaging of Python projects.Changes:
pyproject.tomlsetup.pyandtox.iniThis PR really requires testing before merging into master. I can not say at this stage that everything is correct, but I am opening this PR to test out the changes, see if/where things fail, and get some feedback. Contributions welcome.