This repository has been archived by the owner on Aug 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-t-o-l-a-s
reviewed
Aug 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there ever a use case for a user or instance admin to want to see both the Florence and the Mastodon Version at the same time? It looks like we haven't actually removed lib/mastodon/version.rb
but we've just purged the references to it.
@s-t-o-l-a-s So this actually came up recently; mastodon.py and other libraries use the Mastodon version in the API to determine what features are available. |
1011X
reviewed
Aug 28, 2019
Co-Authored-By: 1011X <1011X@users.noreply.github.com>
clarfonthey
added
A-compatibility
(Affects) compatibility with apps, other software, etc.
C-admin-settings
Admin settings (component)
C-api
API (component)
C-main-view
Main view on web interface (component)
V-feel-bump
Really big, disruptive changes that require a feel (version) bump
V-feature-bump
New features and additions that require a feature (version) bump
and removed
V-feel-bump
Really big, disruptive changes that require a feel (version) bump
labels
Aug 29, 2019
Co-Authored-By: 1011X <1011X@users.noreply.github.com>
1011X
approved these changes
Aug 31, 2019
jhaye
approved these changes
Sep 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-compatibility
(Affects) compatibility with apps, other software, etc.
C-admin-settings
Admin settings (component)
C-api
API (component)
C-main-view
Main view on web interface (component)
V-feature-bump
New features and additions that require a feature (version) bump
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a separate
Florence::Version
module which is separate from the Mastodon version, and will be displayed to the user.