Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Add Florence::Version #156

Merged
merged 6 commits into from
Sep 4, 2019
Merged

Add Florence::Version #156

merged 6 commits into from
Sep 4, 2019

Conversation

clarfonthey
Copy link
Member

This adds a separate Florence::Version module which is separate from the Mastodon version, and will be displayed to the user.

@clarfonthey clarfonthey mentioned this pull request Jul 31, 2019
Open
s-t-o-l-a-s
s-t-o-l-a-s reviewed Aug 27, 2019
View reviewed changes
Copy link

@s-t-o-l-a-s s-t-o-l-a-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ever a use case for a user or instance admin to want to see both the Florence and the Mastodon Version at the same time? It looks like we haven't actually removed lib/mastodon/version.rb but we've just purged the references to it.

@clarfonthey
Copy link
Member Author

@s-t-o-l-a-s So this actually came up recently; mastodon.py and other libraries use the Mastodon version in the API to determine what features are available.

1011X
1011X reviewed Aug 28, 2019
View reviewed changes
lib/cli.rb Show resolved Hide resolved
app/controllers/admin/dashboard_controller.rb Show resolved Hide resolved
app/views/admin/dashboard/index.html.haml Show resolved Hide resolved
app/views/admin/dashboard/index.html.haml Outdated Show resolved Hide resolved
clarfonthey and others added 2 commits August 28, 2019 23:37
@clarfonthey @1011X
Apply suggestions from code review
1205a87 
Co-Authored-By: 1011X <1011X@users.noreply.github.com>
@clarfonthey
Fix indenting from suggestions
db69348
@clarfonthey clarfonthey added A-compatibility (Affects) compatibility with apps, other software, etc. C-admin-settings Admin settings (component) C-api API (component) C-main-view Main view on web interface (component) V-feel-bump Really big, disruptive changes that require a feel (version) bump V-feature-bump New features and additions that require a feature (version) bump and removed V-feel-bump Really big, disruptive changes that require a feel (version) bump labels Aug 29, 2019
clarfonthey and others added 2 commits August 30, 2019 16:54
@clarfonthey @1011X
Update suggestion
90acd35 
Co-Authored-By: 1011X <1011X@users.noreply.github.com>
@clarfonthey
Merge branch 'main' into pr/version
b9bdaae
@1011X 1011X merged commit 2240416 into main Sep 4, 2019
@clarfonthey clarfonthey deleted the pr/version branch September 6, 2019 00:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-t-o-l-a-s s-t-o-l-a-s s-t-o-l-a-s left review comments

@1011X 1011X 1011X approved these changes

@jhaye jhaye jhaye approved these changes

Assignees
No one assigned
Labels
A-compatibility (Affects) compatibility with apps, other software, etc. C-admin-settings Admin settings (component) C-api API (component) C-main-view Main view on web interface (component) V-feature-bump New features and additions that require a feature (version) bump
Milestone
v0.0.2.0 (Pre-Release 0.2.0)
Development

Successfully merging this pull request may close these issues.
4 participants
@clarfonthey @1011X @jhaye @s-t-o-l-a-s