Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 and PHPUnit 9 support #136

Merged
merged 2 commits into from
Dec 28, 2020
Merged

PHP 8 and PHPUnit 9 support #136

merged 2 commits into from
Dec 28, 2020

Conversation

peterdevpl
Copy link

@peterdevpl peterdevpl commented Nov 26, 2020 •
edited
Loading

Upgraded to PHPUnit 9.4; used $this->expectException() instead of annotations, fixed inherited method declarations.

Tested with PHP versions: 7.1.33, 7.2.34, 7.3.24, 7.4.12, 8.0.0RC5.

Fixes #135

@peter279k
Copy link

It seems that the php-8.0 version is not available on Travis CI building environment at this moment.

The related error is as follows:

0.00s0.01s$ phpenv global 8.0
rbenv: version `8.0' not installed
The command "phpenv global 8.0" failed and exited with 1 during .

@peterdevpl
Copy link
Author

@peter279k PHP 8 is available in Travis CI now, and I can see the build passed.

@TimurFlush
Copy link

@florianv Hey

@florianv
Copy link
Owner

@peterdevpl Thanks :) !

@florianv florianv merged commit 88edd27 into florianv:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8 and PHPUnit 9 compatibility
4 participants
@peterdevpl @peter279k @TimurFlush @florianv