Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: made sure that a pitfall of make_sdf is documented #85

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

CommanderStorm
Copy link
Contributor

I had this problem during maplibre/martin#1492
Adding a bit of documentation here might safe future devs a bit of time ^^

Copy link
Owner

@flother flother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very useful, thanks for taking the time to add it. Do you mind if I ask for a few tweaks? Use the imperative mood, capitalise acronyms, and use a line-length of 100 chars, that sort of thing

src/sprite/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Matt Riggott <flother@users.noreply.github.com>
Copy link
Owner

@flother flother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@flother flother merged commit 02d3e76 into flother:master Oct 20, 2024
5 checks passed
@CommanderStorm CommanderStorm deleted the patch-1 branch October 20, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants