Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow switch out of buffertools #20

Open
bakesteve opened this issue Feb 13, 2015 · 4 comments
Open

allow switch out of buffertools #20

bakesteve opened this issue Feb 13, 2015 · 4 comments

Comments

@bakesteve
Copy link

this package relies on buffertools, which uses node-gyp
on windows, that kinda sucks, as there is no dist/executable shipped in the buffertools npm, it does a rebuild from source
this basically means that flowdock has a dependency on python2.7 and visual studio
thats compounded when you look at hubot-flowdock
So, for the functionality this seems to be giving, thats quite a heavy barrier
is there any way you could either:

  • remove buffer tools for something that works out of the box across platforms
  • make it pluggable, so I can at least include a local copy
@lautis
Copy link
Contributor

lautis commented Feb 13, 2015

Replacing the JSON streaming with eventsource could work. Windows users seem to be a quite small minority, so this isn't a very high priority for us. That said, we welcome any pull requests to tackle this.

@bakesteve
Copy link
Author

Err.. Ok. We might look at trying to plug that for you.. Or possibly just go back to slack given that:
A) their stuff just worked
B) they didn't just write off a bunch of folks for 1 line of copying a stream...

On Fri, Feb 13, 2015 at 10:35 pm, Ville Lautanala <notifications@gh.neting.ccmailto:notifications@github.com> wrote:

Replacing the JSON streaming with eventsourcehttps://github.com/aslakhellesoy/eventsource-node could work. Windows users seem to be a quite small minority, so this isn't a very high priority for us. That said, we welcome any pull requests to tackle this.

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-74339396.

@lautis
Copy link
Contributor

lautis commented Feb 14, 2015

Sorry – I didn't mean to write off Windows support. We should get this fixed eventually, but I don't expect anyone to immediately jump to work on this. In the meantime, pull requests either by replacing our current uses of buffertools with pure javascript or some other methods would be appreciated especially since we don't have Windows development machines and our knowledge about Node on Windows is pretty much based on issues like this.

@bakesteve
Copy link
Author

Ok – will push something up if one of us gets a chance. For now we are getting round it by including a built version of buffertools and changing our gitignore so that gets pulled with the rest of our hubot repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants