-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow switch out of buffertools #20
Comments
Replacing the JSON streaming with eventsource could work. Windows users seem to be a quite small minority, so this isn't a very high priority for us. That said, we welcome any pull requests to tackle this. |
Err.. Ok. We might look at trying to plug that for you.. Or possibly just go back to slack given that: On Fri, Feb 13, 2015 at 10:35 pm, Ville Lautanala <notifications@gh.neting.ccmailto:notifications@github.com> wrote: Replacing the JSON streaming with eventsourcehttps://github.com/aslakhellesoy/eventsource-node could work. Windows users seem to be a quite small minority, so this isn't a very high priority for us. That said, we welcome any pull requests to tackle this. Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-74339396. |
Sorry – I didn't mean to write off Windows support. We should get this fixed eventually, but I don't expect anyone to immediately jump to work on this. In the meantime, pull requests either by replacing our current uses of buffertools with pure javascript or some other methods would be appreciated especially since we don't have Windows development machines and our knowledge about Node on Windows is pretty much based on issues like this. |
Ok – will push something up if one of us gets a chance. For now we are getting round it by including a built version of buffertools and changing our gitignore so that gets pulled with the rest of our hubot repo |
this package relies on buffertools, which uses node-gyp
on windows, that kinda sucks, as there is no dist/executable shipped in the buffertools npm, it does a rebuild from source
this basically means that flowdock has a dependency on python2.7 and visual studio
thats compounded when you look at hubot-flowdock
So, for the functionality this seems to be giving, thats quite a heavy barrier
is there any way you could either:
The text was updated successfully, but these errors were encountered: