Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a draft of the module #1

Closed
simoferr98 opened this issue Jul 20, 2022 · 0 comments · Fixed by #2
Closed

Create a draft of the module #1

simoferr98 opened this issue Jul 20, 2022 · 0 comments · Fixed by #2
Assignees
@simoferr98
Labels
good first issue Good for newcomers

Comments

@simoferr98
Copy link
Contributor

simoferr98 commented Jul 20, 2022 •
edited
Loading

Write an initial draft of a module that manages at least these resources:

  • aws_imagebuilder_component
  • aws_imagebuilder_image_recipe
  • aws_imagebuilder_infrastructure_configuration
  • aws_imagebuilder_distribution_configuration
  • aws_imagebuilder_image_pipeline

The module initially only manages the creation of AMIs and not Container Image.

A new issue will be made to implement the resources as well:

  • aws_imagebuilder_container_recipe
@simoferr98 simoferr98 added the good first issue Good for newcomers label Jul 20, 2022
@simoferr98 simoferr98 self-assigned this Jul 20, 2022
simoferr98 pushed a commit that referenced this issue Jul 20, 2022
feat: initial draft #1
b09915e
@simoferr98 simoferr98 mentioned this issue Aug 4, 2022
Merged
@simoferr98 simoferr98 linked a pull request Aug 4, 2022 that will close this issue
1 create a draft of the module #2
Merged
simoferr98 added a commit that referenced this issue Aug 4, 2022
@simoferr98
feat: initial draft #1 (#2)
569f5d2 
* feat: initial draft #1

* fix: changes in the code following the tests done to the module.

The code in the present resource block was changed without adding any
new resources.

* fix: change the description of the output component_name and component_arn

* feat(examples): add of the complete example

* fix (terraform version) change terraform required version

* fix (examples): in the variables in the main and in the README.md

- Added new variables in README.md and revised descriptions
- variables.tf changed the description of the variables and added the variable launch_template_id_2
- main.tf changed the code of the module
- versions.tf changed the terraform required version and required providers

* fix (module): change file variables.tf, main.tf,version.tf and outputs.tf
- variables.tf changed the description and type
- outputs.tf changed the descriptyion
- main.tf changed the code of the module
- versions.tf changed the terraform required version and required providers

* docs: add README.md

Co-authored-by: Simone Ferraro <simone.ferraro@flowing.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoferr98 simoferr98

Labels
good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1 create a draft of the module flowingis/terraform-aws-ec2-image-builder
1 participant
@simoferr98