fix: destory attribute then element is removed

flowjs · Dec 4, 2013 · 8d8c67e · 8d8c67e
1 parent dcfd7cb
commit 8d8c67e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/directives/init.js b/src/directives/init.js
@@ -51,6 +51,9 @@ function ($scope, $attrs, $parse, flowFactory) {
     }
   });
   $parse(name).assign($scope, flow);
+  $scope.$on('$destroy', function () {
+    $parse(name).assign($scope);
+  });
 }])
 .directive('ngFlowInit', [function() {
   return {

diff --git a/test/init.spec.js b/test/init.spec.js
@@ -38,4 +38,17 @@ describe('init', function() {
     expect($rootScope.obj.flow instanceof Flow).toBeTruthy();
     expect($rootScope.obj.flow).toBe(elementScope.obj.flow);
   });
+
+  it('should destroy $flow', function() {
+    $rootScope.obj = {flow:''};
+    $rootScope.show = true;
+    element = $compile('<div ng-flow-init="{}" ng-if="show" ng-flow-name="obj.flow"></div>')($rootScope);
+    $rootScope.$digest();
+    elementScope = element.scope();
+    expect($rootScope.obj.flow).toBeDefined();
+    expect($rootScope.obj.flow instanceof Flow).toBeTruthy();
+    $rootScope.show = false;
+    $rootScope.$digest();
+    expect($rootScope.obj.flow).toBeUndefined();
+  });
 });