Fix bugs with parsing to and from timezones #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split handling of parsed and moment return values Improved tests: Verify the results of the parsed dates.
fiznool
reviewed
Feb 13, 2017
lib/index.js
Outdated
| }); | ||
| var tz = moment.tz.guess() || 'UTC'; | ||
| Utils.Logger.warn('Utils.parseDateTimeField - Timezone "' + timezone + '" is invalid. Assuming ' + tz); | ||
| timezone = tz; |
There was a problem hiding this comment.
We're changing timezone here but the options.locale was already decided above, with the old timezone. Does line 445 need to be moved to below this if block to take the new timezone into account?
There was a problem hiding this comment.
Yes, good catch!
lib/index.js
Outdated
| var parsedDateWithTimezone = parseDateTime(field, options, timezone); | ||
| if (SugarDate.isValid(parsedDateWithTimezone)) { | ||
| Utils.Logger.debug('Utils.parseDateTimeField: parsedDateWithTimezone:', parsedDateWithTimezone.toISOString()); | ||
|
|
||
| var hasTZOffset = new RegExp('[+-]{1}[0-9]{2}:?[0-9]{2}').test(field); |
There was a problem hiding this comment.
I know this wasn't part of the changes but maybe this regex could be tightened up? How about:
/(?:[zZ]|[+-][01]\d:[0-5]\d)$/.test(field)
This takes into account:
- a UTC
Ztimezone offset - the fact that
+99:99isn't a valid timezone offset.
There was a problem hiding this comment.
Thanks, I ended up with.
/[zZ]|[+-][01]\d:?[0-5]\d/
I removed the $ to allow for dates with our custom offset. 2013-02-08 09:30+07:00 +1d - 12h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.