input_chunk: info level instead of debug for chunk removal msg #6719
Conversation
PettitWesley
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
src/flb_input_chunk.c
Outdated
| flb_debug("[input chunk] remove route of chunk %s with size %ld bytes to output plugin %s " | ||
| "to place the incoming data with size %ld bytes", flb_input_chunk_get_name(old_ic), | ||
| old_ic_bytes, o_ins->name, chunk_size); | ||
| flb_info("[input chunk] remove route of chunk %s with size %zd bytes to output plugin %s " |
There was a problem hiding this comment.
the format specifiers here were wrong according to my understanding.
old_ic_bytes is ssize_t which should use %zd for signed type, and then the others are size_t which is unsigned and needs %zu
There was a problem hiding this comment.
In terms of changing from debug => info, my thinking was that the user should get a clear message when chunks are being deleted.
There was a problem hiding this comment.
if I am not wrong the debug message is a "hint" to tell the user/debugger the chunk "aims to be removed", actually that routine is trying to find a candidate since the queue is full, then the logic depends on routes/mask, at that level of the message is not really removed.
cc: @leonardo-albertovich @pwhelan -> I think you both were involved in those changes, can you comment ?
There was a problem hiding this comment.
Ok, in that case then I think the debug message on line 624 should be info and should be updated since that is where the deletion truly happens? And then here the debug message should say something like "Attempt to remove".
There was a problem hiding this comment.
flb_task_destroy also destroys the chunk backing the task. You would need to change the call to flb_debug on both lines 616 and 624.
There was a problem hiding this comment.
Ack. I will update to that.
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
PettitWesley
force-pushed
the
chunk-removal-info
branch
from
6ab1e6f to
f95ab95
Compare
…t#6719) Signed-off-by: Wesley Pettit <wppttt@amazon.com> Signed-off-by: root <root@sumit-acs.novalocal>
…t#6719) Signed-off-by: Wesley Pettit <wppttt@amazon.com>
…t#6719) Signed-off-by: Wesley Pettit <wppttt@amazon.com>
…t#6719) Signed-off-by: Wesley Pettit <wppttt@amazon.com>
…t#6719) Signed-off-by: Wesley Pettit <wppttt@amazon.com>
…t#6719) Signed-off-by: Wesley Pettit <wppttt@amazon.com>
…t#6719) Signed-off-by: Wesley Pettit <wppttt@amazon.com>
…t#6719) Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit wppttt@amazon.com
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.