Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: sts_credentials: make STS response parsing less brittle by check… #7313

Closed
wants to merge 1 commit into from

Conversation

PettitWesley
Copy link
Contributor

…ing for the full XML end node


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

…ing for the full XML end node

Signed-off-by: Wesley Pettit <wppttt@amazon.com>
@PettitWesley PettitWesley marked this pull request as draft May 4, 2023 02:13
@PettitWesley
Copy link
Contributor Author

Has not been tested thoroughly yet.

@PettitWesley PettitWesley temporarily deployed to pr May 4, 2023 02:13 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 4, 2023 02:13 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 4, 2023 02:13 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 4, 2023 02:31 — with GitHub Actions Inactive
@PettitWesley PettitWesley marked this pull request as ready for review May 10, 2023 22:02
@PettitWesley
Copy link
Contributor Author

Tested by running STS cred unit test under valgrind. And tested with this config:

[INPUT]
    Name dummy
    Tag dummy

[OUTPUT]
    Name  kinesis_firehose
    Match *
    region cn-north-1
    delivery_stream PUT-S3-vNRcC
    role_arn arn:aws-cn:iam::222222222222222:role/firehose-external-id
    external_id external-id-test

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 23, 2023
@PettitWesley
Copy link
Contributor Author

released in AWS Distro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant