filter_ecs: Retrieve container ID from record field #9033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaJiska
force-pushed
the
filter-ecs-container-id-field
branch
from
85c937c
to
b4ba446
Compare
Signed-off-by: Ra'Jiska <dodo.lasticot@gmail.com>
RaJiska
force-pushed
the
filter-ecs-container-id-field
branch
from
b4ba446
to
f14ac5f
Compare
Signed-off-by: Ra'Jiska <dodo.lasticot@gmail.com>
|
the PR is not passing the unit test: https://github.com/fluent/fluent-bit/actions/runs/9771469517/job/27099695827?pr=9033 |
Signed-off-by: Ra'Jiska <dodo.lasticot@gmail.com>
RaJiska
force-pushed
the
filter-ecs-container-id-field
branch
from
da51c32
to
59cd20b
Compare
|
@edsiper Added format checks as well as well as an extra test for invalid data. |
|
@edsiper One of the test fails, though it doesn't seem related to the changes I made, is this a random failure or was some kind of side-effect introduced? I had all passing when running locally. |
|
Bump @edsiper @PettitWesley |
|
Bump @edsiper @PettitWesley 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
container_id_field_nameto retrieve the container ID instead of deducing it from the tags viaecs_tag_prefixwhich is too restrictive to use as too invasive over the logic the user wants to use.Maintained the retrieval of the container ID to not introduce breaking change, but using
container_id_field_namewill override and retrieve container ID from the specified field.Fixes the following issue: #9028
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
fluentbit-valgrind-containerid.txt
fluentbit-valgrind-ecsprefix.txt
The above includes config file as well as debug outputs.
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
pipelines: filters: ecs: Retrieve container ID from record field fluent-bit-docs#1402
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.