-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom_calyptia: honour collector interval in secs and nano secs. #9648
Conversation
7ba662a
to
fa18790
Compare
fa18790
to
2eb4cb6
Compare
2eb4cb6
to
68ecb95
Compare
@niedbalski Since the PR and commits touch different components, we need, as a minimum for this case 2 commits, one per plugin, ref: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes . This is to have a clean history and log per component. As soon as the commits are fixed we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I've overlooked that this PR touches the different components in the same commit.
We have to split commits and commit again with the same groups.
The changes should be reasonable. Just commit issue.
68ecb95
to
d72b40e
Compare
Description
This change makes the custom calyptia plugin honour the configured collector
interval (both in secs and nanosecs) that is cascaded to the instantiated input fleet plugin.
Also, I took the chance to add unit test to validate the cascade of properties to the underlying
fleet plugin.
Testing
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.