Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to call #format_stream of plugin themselves when RecordFilter mixin included #1005

Merged
merged 1 commit into from
May 30, 2016
Merged

Fix to call #format_stream of plugin themselves when RecordFilter mixin included #1005

merged 1 commit into from
May 30, 2016

Conversation

tagomoris
Copy link
Member

  • because RecordFilter depends on #format_stream implemented by that mixin itself
  • it is same with the case that plugins re-implements #format_stream

@tagomoris
Fix to call #format_stream of plugin themselves when RecordFilter mix…
0319614 
…in included

* because RecordFilter depends on #format_stream implemented by that mixin itself
*   it is same with the case that plugins re-implements #format_stream
@tagomoris
Copy link
Member Author

This change fixes #1004.

@okkez
Copy link
Contributor

okkez commented May 30, 2016

It works! LGTM.

@sonots sonots mentioned this pull request May 30, 2016
Closed
@tagomoris tagomoris merged commit 9cd3e1c into master May 30, 2016
@tagomoris
Copy link
Member Author

Merged.

@tagomoris tagomoris deleted the fix-call-filter_record-from-compat-v14 branch May 30, 2016 08:35
@okkez okkez mentioned this pull request May 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tagomoris @okkez