-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1068] Add delimiter option to parser_csv #1108
[#1068] Add delimiter option to parser_csv #1108
Conversation
llby
commented
Jul 17, 2016
•
edited
Loading
edited
- some test dosen't run. because it has not arg 'param'.
- CSV.parse_line return nil from empty. so flag 'null_empty_string' do nothing.
- and same problem has test_parser_tsv.rb
Do you mean that adding |
|
Okay, I understood that |
def parse(text) | ||
yield values_map(CSV.parse_line(text)) | ||
yield values_map(CSV.parse_line(text,{col_sep: @delimiter})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use keyword argument style instead of specifying a hash object: CSV.parse_line(text, col_sep: @delimiter)
I created a pull-request to fix bugs you pointed: #1112 |
I merged #1112 . |
done. |
Great addition. Thanks! |