Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fluent namespace to ConfigError in v0.14 API based plugins #1223

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

repeatedly
Copy link
Member

One user reports following error:

2016-09-09 09:01:49 +0000 [error]: fluent/supervisor.rb:567:rescue in main_process: unexpected error error="uninitialized constant Fluent::Plugin::GrepFilter::ConfigError

@repeatedly repeatedly added bug Something isn't working v0.14 labels Sep 9, 2016
@tagomoris
Copy link
Member

👍 - but, it's better to add tests to assert_raised for these configuration errors.

@tagomoris tagomoris assigned repeatedly and unassigned tagomoris Sep 13, 2016
@repeatedly
Copy link
Member Author

but, it's better to add tests to assert_raised for these configuration errors.

I agree but this changes several plugins across plugin types.
I think separating PR is good for me.
We have a room for test improvement, use data instead of each and more.

@tagomoris
Copy link
Member

Ah, you're right.

@tagomoris tagomoris merged commit 209b820 into master Sep 26, 2016
@repeatedly repeatedly deleted the add-fluent-namespace-to-v014-plugins branch September 26, 2016 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants