Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise ConfigError when same label appears twice, or no match appears in label #1233

Merged

Conversation

tagomoris
Copy link
Member

This change fixes the 2 <label> related bugs:

no <match> sections in <label> isn't reported

<label @test>
  @type stdout
</label>

This is clearly wrong configuration, and warning "no patterns matched" appears always for @test label.
This change raises configuration error for such configuration.

same label configured twice

<label @test>
  # first
</label>
<label @test>
  # last
</label>

Currently, Fluentd uses the last configuration for same labels without any errors nor warnings.
This configuration is clearly a misconfiguration. So this change is to make to report such configurations as errors.

@tagomoris
Copy link
Member Author

@repeatedly review this please.

@repeatedly
Copy link
Member

Good catch!

@repeatedly repeatedly merged commit 24e15f3 into master Sep 19, 2016
@ganmacs ganmacs deleted the raise-configuration-error-for-invalid-label-configuration branch July 11, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants