parser/formatter plugin helper with default @type in plugin side #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to allow overriding default values in config sections.
…with default values specified in plugin code. This change makes plugin authors to call `parser_create`/`formatter_create` without any arguments to create parser/formatter instances with consideration about default values specified in plugin code. If `conf` or `type` specified, plugin helper considers that plugin code will create plugin instance manually, and skip plugin usage (default blank string).
This change includes: * update `in_syslog` using parser helper, and shrink code of implementation * previous code works in different way by conf['format'] * but it doesn't work well when `parser_syslog` used and `with_priority` is false * delete duplicated implementation between `out_stdout` and `filter_stdout`(`formatter_stdout`)
tagomoris
force-pushed
the
unify-out-filter-stdout-formatting
branch
from
be68fbd to
0332010
Compare
|
@repeatedly could you review this change please? |
tagomoris
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
multi: trueforconfig_section :parseandconfig_section :formathelps plugin authors not to useconfordefault_typeargument inparser_createandformatter_create.With this change, plugin authors can write code to create parser(formatter) instances with default parser(formatter).
After this change, parser(formatter) plugin helpers always requires default
@typedefinition.I believe that it's reasonable change for all plugins which uses parsers/formatters.