Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supervisor: Clear previous worker pids when receives kill signals. ref #1674 #1683

Merged
merged 1 commit into from
Sep 6, 2017
Merged

supervisor: Clear previous worker pids when receives kill signals. ref #1674 #1683

merged 1 commit into from
Sep 6, 2017

Conversation

repeatedly
Copy link
Member

Without this patch, sending multiple signals, e.g. call kill -HUP pid twice, causes "No such process"

@repeatedly repeatedly requested a review from mururu September 5, 2017 07:38
@repeatedly repeatedly self-assigned this Sep 5, 2017
@repeatedly repeatedly added bug Something isn't working v0.14 labels Sep 5, 2017
@repeatedly
Copy link
Member Author

@mururu Could you check?

@repeatedly repeatedly mentioned this pull request Sep 5, 2017
Closed
mururu
mururu approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@mururu mururu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@repeatedly repeatedly merged commit d14ea82 into master Sep 6, 2017
@repeatedly repeatedly deleted the clear-worker-pid-after-kill branch September 6, 2017 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mururu mururu mururu approved these changes

Assignees

@repeatedly repeatedly

Labels
bug Something isn't working v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @mururu