Use Strftime to improve fixed timestamp performance #1796
Merged
+42
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
force-pushed
the
use-precompiled-strftime
branch
from
76d1422 to
80e45ea
Compare
|
@mururu Could you also check this? |
mururu
reviewed
Dec 28, 2017
|
|
||
| config_param :output_type, :string, default: 'json' | ||
|
|
||
| def configure(conf) | ||
| super | ||
|
|
||
| @time_formatter = Strftime.new(TIME_FORMAT) |
There was a problem hiding this comment.
Yes because TIME_FORMAT is fixed.
mururu
reviewed
Dec 28, 2017
lib/fluent/log.rb
Outdated
| @formatter = Proc.new { |type, time, level, msg| | ||
| r = { | ||
| 'time' => time.strftime(@time_format), | ||
| 'time' => @time_formatter ? @time_formatter.exec(time) : time.strftime(@time_format), |
There was a problem hiding this comment.
How about defining method for @time_formatter ? @time_formatter.exec(time) : time.strftime(@time_format)?
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Strftimeinstead ofTime#strftimeimproves the performance of time formatting.