Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_file: Create directory for symlink. fix #2346 #2353

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

repeatedly
Copy link
Member

Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com

Which issue(s) this PR fixes:
Fixes #2346

What this PR does / why we need it:
Create directory when parent directories don't exist.

Docs Changes:
No need.

Release Note:
Use title

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly added bug Something isn't working v1 labels Mar 28, 2019
@repeatedly repeatedly self-assigned this Mar 28, 2019
@repeatedly repeatedly requested a review from cosmo0920 March 28, 2019 23:56
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that this patch fixes #2346.
BTW, this PR needn't adding test case(s) for this change?

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly
Copy link
Member Author

Just changed test case to check this patch.

@cosmo0920
Copy link
Contributor

Additional test case commit also looks good to me. 👍

@repeatedly repeatedly merged commit 3f37357 into master Mar 29, 2019
@ganmacs ganmacs deleted the create-dir-for-symlink branch July 11, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with symlink_path and placeholder
2 participants