Fix log rotete age error handling #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
nothing
What this PR does / why we need it:
Kernel.#Integer can raise ArgumentError https://docs.ruby-lang.org/ja/2.5.0/method/Kernel/m/Integer.html (Sorry. but I wasn't able to find the English document...
English document which I found(https://ruby-doc.org/core-2.5.1/Kernel.html#method-i-Integer) doesn't refer to ArgumentError. )
And I also noticed the variable name (
rotate_ages) is used.https://ruby-doc.org/core-2.5.1/Kernel.html
Docs Changes:
not needed
Release Note:
not needed