test_in_udp: add timeout for message_length_limit test #4676
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
test-message_length_limit
branch
2 times, most recently
from
ea28489 to
a29b537
Compare
|
Memo: On windows, data over |
ashie
reviewed
Oct 21, 2024
On Windows, `message_length_limit` test always take 300s for execution. ``` UdpInputTest: test: configure w/o parse section: .: (0.002351) test: configure[ipv4]: .: (0.002723) test: configure[ipv6]: .: (0.002602) test: message size with format[none]: .: (1.029781) test: message size with format[json]: .: (1.113799) test: message size with format[regexp]: .: (1.110006) test: message_length_limit: .: (300.538596) ``` The 300 sec comes from https://github.com/fluent/fluentd/blob/a2b935ae2bc4b4d43e5adddbec01092ea4228b9e/lib/fluent/test/driver/base.rb#L36, and it always times out in Windows. This patch set a short timeout to reduce test execution time on Windows. Signed-off-by: Watson <fujita@clear-code.com>
Watson1978
force-pushed
the
test-message_length_limit
branch
from
a29b537 to
35360b4
Compare
ashie
added a commit
that referenced
this pull request
Oct 22, 2024
Although it's improved in #4676, it still takes 5 seconds on windows. It can be reduced more by sending data that doesn't exceed the limit. ``` test: message_length_limit: .: (1.104855) ``` Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
On Windows,
message_length_limittest always take 300s for execution.The 300 sec comes from
fluentd/lib/fluent/test/driver/base.rb
Line 36 in a2b935a
This patch set a short timeout to reduce test execution time on Windows.
Docs Changes:
Release Note: