Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add style keys for some ribbon controls #1178

Conversation

nishy2000
Copy link
Contributor

@nishy2000 nishy2000 commented Oct 8, 2023

Fix Issue #1177.

I added a style key for the ribbon control.
This is to allow for the creation of custom styles based on the original ribbon control style.

At the same time, key names for styles and templates with different naming conventions have been corrected.

Key names added or changed are as follows.

Old New
--- Fluent.Ribbon.Styles.ApplicationMenu
Fluent.Ribbon.Templates.ApplicationMenuButton Fluent.Ribbon.Templates.ApplicationMenu
--- Fluent.Ribbon.Styles.ColorGallery
Fluent.Ribbon.Styles.RibbonComboButton Fluent.Ribbon.Styles.ComboBox.ToggleButton
--- Fluent.Ribbon.Styles.ComboBox
Fluent.Ribbon.Templates.RibbonComboButton Fluent.Ribbon.Templates.ComboBox.ToggleButton
Fluent.Ribbon.Templates.RibbonCombobox Fluent.Ribbon.Templates.ComboBox
--- Fluent.Ribbon.Styles.InRibbonGallery
--- Fluent.Ribbon.Styles.RadioButton
--- Fluent.Ribbon.Styles.RibbonMenu
--- Fluent.Ribbon.Styles.TextBox
--- Fluent.Ribbon.Styles.ScrollBar
--- Fluent.Ribbon.Styles.StatusBar
--- Fluent.Ribbon.Styles.StatusBarMenuItem
--- Fluent.Ribbon.Styles.WindowCommands

| Old                                           | New                                           |
|-----------------------------------------------|-----------------------------------------------|
| ---                                           | Fluent.Ribbon.Styles.ApplicationMenu          |
| Fluent.Ribbon.Templates.ApplicationMenuButton | Fluent.Ribbon.Templates.ApplicationMenu       |
| ---                                           | Fluent.Ribbon.Styles.ColorGallery             |
| Fluent.Ribbon.Styles.RibbonComboButton        | Fluent.Ribbon.Styles.ComboBox.ToggleButton    |
| ---                                           | Fluent.Ribbon.Styles.ComboBox                 |
| Fluent.Ribbon.Templates.RibbonComboButton     | Fluent.Ribbon.Templates.ComboBox.ToggleButton |
| Fluent.Ribbon.Templates.RibbonCombobox        | Fluent.Ribbon.Templates.ComboBox              |
| ---                                           | Fluent.Ribbon.Styles.RibbonMenu               |
| ---                                           | Fluent.Ribbon.Styles.TextBox                  |
| ---                                           | Fluent.Ribbon.Styles.ScrollBar                |
| ---                                           | Fluent.Ribbon.Styles.StatusBarMenuItem        |
| ---                                           | Fluent.Ribbon.Styles.WindowCommands           |
In the last commit, there were some omissions in the addition of the style key.
Add the following three keys.
- Fluent.Ribbon.Styles.InRibbonGallery
- Fluent.Ribbon.Styles.RadioButton
- Fluent.Ribbon.Styles.StatusBar

| Old                                           | New                                           |
|-----------------------------------------------|-----------------------------------------------|
| ---                                           | Fluent.Ribbon.Styles.ApplicationMenu          |
| Fluent.Ribbon.Templates.ApplicationMenuButton | Fluent.Ribbon.Templates.ApplicationMenu       |
| ---                                           | Fluent.Ribbon.Styles.ColorGallery             |
| Fluent.Ribbon.Styles.RibbonComboButton        | Fluent.Ribbon.Styles.ComboBox.ToggleButton    |
| ---                                           | Fluent.Ribbon.Styles.ComboBox                 |
| Fluent.Ribbon.Templates.RibbonComboButton     | Fluent.Ribbon.Templates.ComboBox.ToggleButton |
| Fluent.Ribbon.Templates.RibbonCombobox        | Fluent.Ribbon.Templates.ComboBox              |
| ---                                           | Fluent.Ribbon.Styles.InRibbonGallery          |
| ---                                           | Fluent.Ribbon.Styles.RadioButton              |
| ---                                           | Fluent.Ribbon.Styles.RibbonMenu               |
| ---                                           | Fluent.Ribbon.Styles.TextBox                  |
| ---                                           | Fluent.Ribbon.Styles.ScrollBar                |
| ---                                           | Fluent.Ribbon.Styles.StatusBar                |
| ---                                           | Fluent.Ribbon.Styles.StatusBarMenuItem        |
| ---                                           | Fluent.Ribbon.Styles.WindowCommands           |
@nishy2000
Copy link
Contributor Author

Hi, @batzen

I think the "Breaking Change" is that I have changed the existing key names.
Is it possible to have it applied to v10 series (not v11 series) if I only add new key names and do not rename the existing key name?
If yes, I will push a new commit that does not change the existing key names.

@batzen
Copy link
Member

batzen commented Oct 11, 2023

Hi @nishy2000

changing something that might have been previously used by users/consumers is a breaking change.
Just adding new keys is, of course, no breaking change. ;-)
If you change the PR to just add new keys i could include it in the next minor version (10.1) update.
New keys are a new "feature" so i have to increase the minor version, instead of just the patch version.
But that's no problem.

You could create a separate PR where you rename the keys and base it off of the branch "features/new_office_theme" instead of the develop branch as the office theme branch is the one i am currently working on features for version 11.

| Old                                           | New                                           |
|-----------------------------------------------|-----------------------------------------------|
| ---                                           | Fluent.Ribbon.Styles.ApplicationMenu          |
| ---                                           | Fluent.Ribbon.Styles.ColorGallery             |
| ---                                           | Fluent.Ribbon.Styles.ComboBox                 |
| ---                                           | Fluent.Ribbon.Styles.InRibbonGallery          |
| ---                                           | Fluent.Ribbon.Styles.RadioButton              |
| ---                                           | Fluent.Ribbon.Styles.RibbonMenu               |
| ---                                           | Fluent.Ribbon.Styles.TextBox                  |
| ---                                           | Fluent.Ribbon.Styles.ScrollBar                |
| ---                                           | Fluent.Ribbon.Styles.StatusBar                |
| ---                                           | Fluent.Ribbon.Styles.StatusBarMenuItem        |
| ---                                           | Fluent.Ribbon.Styles.WindowCommands           |
@nishy2000
Copy link
Contributor Author

Hi @batzen

Sounds good.

I pushed the new commit that does not change the existing key names.

Thanks.

@batzen batzen modified the milestones: 11.0, 10.0.5 Oct 17, 2023
@batzen batzen merged commit c6bae12 into fluentribbon:develop Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants