Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff linter #1082

Closed
JchavesM opened this issue May 4, 2023 · 3 comments
Closed

Add ruff linter #1082

JchavesM opened this issue May 4, 2023 · 3 comments
Labels
difficulty::medium

Comments

@JchavesM
Copy link

JchavesM commented May 4, 2023 •
edited
Loading

Considering how fast it is, we should support ruff within makes' python linters.

Relevant links

/lintPython settings
Prospector settings
Issue to add ruff to prospector
sebas031811 added a commit to sebas031811/makes that referenced this issue Jun 22, 2023
@sebas031811
feat(build): fluidattacks#1082 add ruff dependency
6be504b 
Signed-off-by: Sebastian Cardona <sebas03181@gmail.com>
sebas031811 added a commit to sebas031811/makes that referenced this issue Jun 22, 2023
@sebas031811
feat(build): fluidattacks#1082 add ruff dependency
ceebc26 
Signed-off-by: Sebastian Cardona <sebas03181@gmail.com>
@dsalaza4
Copy link
Contributor

⚠️ This issue is currently blocked as Prospector does not support Ruff yet: prospector-dev/prospector#601

@dacevedo12
Copy link
Collaborator

prospector-dev/prospector#694 was just merged

@dsalaza4
Copy link
Contributor

I am thinking about stopping support for most builtins. I would rather moving the lintPython logic to universe and handling it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty::medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsalaza4 @JchavesM @dacevedo12