Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makePythonLock adds win deps to sources.yaml #1172

Closed
jgomezb11 opened this issue Sep 27, 2023 · 0 comments
Closed

makePythonLock adds win deps to sources.yaml #1172

jgomezb11 opened this issue Sep 27, 2023 · 0 comments

Comments

@jgomezb11
Copy link
Contributor

jgomezb11 commented Sep 27, 2023

What is the current bug behavior? how can we reproduce it?

Can't update deps because makePythonLock is adding a .whl of a win-arm64 dependency in the sources.yaml; and as result the makePythonPypiEnvironment fails.

The current bug is ocurring with a dependency named pywin32 v306 that is a required by azure-identity: 1.14.0

What is the expected correct behavior?

makePythonLock should ignore windows wheels because we don't support that OS.

Relevant logs and/or screenshots

https://gitlab.com/fluidattacks/universe/-/commit/d5f89f26a29de6c701683c66f925daeaeb459691#f27889a9c3ae0dc3d73a8acd7ca572b2d4cc33cc_1007_1033

Possible fixes

A possible fix would be to exclude -win_arm64.whl deps inside the logic of makePythonLock

jgomezb11 added a commit to jgomezb11/makes that referenced this issue Sep 27, 2023
- add exclusion for win_arm64 wheels inside makePythonLock
- exclude packages without links from the sources.yaml

Signed-off-by: Julian Gomez Benitez <60365681+jgomezb11@users.noreply.github.com>
jgomezb11 added a commit to jgomezb11/makes that referenced this issue Sep 27, 2023
- add exclusion for win_arm64 wheels inside makePythonLock
- exclude packages without links from the sources.yaml
- add mail to mailmap
- fix format errors

Signed-off-by: Julian Gomez <jgomezb11@eafit.edu.co>
jgomezb11 added a commit to jgomezb11/makes that referenced this issue Sep 28, 2023
- add exclusion for win_arm64 wheels inside makePythonLock
- exclude packages without links from the sources.yaml
- add mail to mailmap
- fix format errors

Signed-off-by: Julian Gomez <jgomezb11@eafit.edu.co>
dsalaza4 added a commit that referenced this issue Sep 28, 2023
refac(back): #1172 ignore win-arm64 wheels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants