Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize deployContainer and deployContainerManifest #1364

Closed
dsalaza4 opened this issue Aug 12, 2024 · 0 comments
Closed

Standardize deployContainer and deployContainerManifest #1364

dsalaza4 opened this issue Aug 12, 2024 · 0 comments
Assignees
@dsalaza4

Comments

@dsalaza4
Copy link
Contributor

deployContainer receives parameters like registry, whereas deployContainerManifest receives parameters like config. They serve very similar purposes and will be used together most times.

Let's standardize parameters on both builtins in order to reduce boilerplate.
@dsalaza4 dsalaza4 self-assigned this Aug 12, 2024
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Aug 12, 2024
@dsalaza4
refac(back): fluidattacks#1364 remove config
4b83004 
- Remove config parameter in favor of a more flat approach
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Aug 12, 2024
@dsalaza4
refac(back): fluidattacks#1364 remove config
ef6ee4e 
- Remove config parameter in favor of a more flat approach
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Aug 12, 2024
@dsalaza4
refac(back): fluidattacks#1364 remove config
283b5e9 
- Remove config parameter in favor of a more flat approach

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit that referenced this issue Aug 12, 2024
@dsalaza4
Merge pull request #1365 from dsalaza4/dsalazaratfluid
c0e379b 
refac(back): #1364 remove config
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Aug 12, 2024
@dsalaza4
feat(back): fluidattacks#1364 new version
a606f97 
- Add new 24.09 pre-release version
- Make 24.02 stable version

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit that referenced this issue Aug 12, 2024
@dsalaza4
Merge pull request #1366 from dsalaza4/dsalazaratfluid
32ac0be 
feat(back): #1364 new version
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Aug 12, 2024
@dsalaza4
refac(back): fluidattacks#1364 simplify deploy container
40b10c9 
- Make it simpler and consistent with deployContainerManifest
- Remove `images` option in favor of a flat approach
- Remove attempts logic for simplicity
- Update documentation

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Aug 12, 2024
@dsalaza4
refac(back): fluidattacks#1364 simplify deploy container
81bc9db 
- Make it simpler and consistent with deployContainerManifest
- Remove `images` option in favor of a flat approach
- Remove attempts logic for simplicity
- Update documentation

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Aug 12, 2024
@dsalaza4
refac(back): fluidattacks#1364 simplify deploy container
e4e34b7 
- Make it simpler and consistent with deployContainerManifest
- Remove `images` option in favor of a flat approach
- Remove attempts logic for simplicity
- Update documentation

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
acuberosatfluid added a commit that referenced this issue Aug 12, 2024
@acuberosatfluid
Merge pull request #1367 from dsalaza4/dsalazaratfluid
9cfda44 
refac(back): #1364 simplify deploy container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsalaza4 dsalaza4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsalaza4